On Mon, Jul 17, 2017 at 9:42 AM, Benjamin Smedberg <benja...@smedbergs.us> wrote:
> I don't know really anything about how rust panics get reflected into > crash-data. Who would be the right person to talk to about that? > Rust panics are equivalent to MOZ_CRASHES, and we treat them as such (or at least try to, see bug 1379857). Rust makes it easier to put non-constant things in the crash strings, which can be quite useful (see [1] as an example). They're not used often, and it seems unlikely that the existing use-cases would pose privacy issues, but I don't have a good proposal for enforcing that. [1] http://searchfox.org/mozilla-central/rev/01d27fdd3946f7210da91b18fcccca01d7324fe2/servo/components/style/thread_state.rs#74 > > --BDS > > On Mon, Jul 17, 2017 at 12:40 PM, Emilio Cobos Álvarez <emi...@crisal.io> > wrote: > > > On 07/17/2017 05:18 PM, Benjamin Smedberg wrote:> Unlike MOZ_CRASH, > > which only annotates crashes with compile-time constants > > > which are inherently not risky, both MOZ_CRASH_UNSAFE_OOL and > > > MOZ_CRASH_UNSAFE_PRINTF can annotate crashes with arbitrary data. Crash > > > reasons are publicly visible in crash reports, and in general it is not > > > appropriate to send any kind of user data as part of the crash reason. > > > > I suppose the same happens with rust panics, should those also be > reviewed? > > > > -- Emilio > > _______________________________________________ > > dev-platform mailing list > > dev-platform@lists.mozilla.org > > https://lists.mozilla.org/listinfo/dev-platform > > > _______________________________________________ > dev-platform mailing list > dev-platform@lists.mozilla.org > https://lists.mozilla.org/listinfo/dev-platform > _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
