I'm so happy for this hammer to slam down. Goodbye, at least a good bit of horrible DLL injections and crashes, and horrible BaseThreadInitThunk. Thanks for the explanation. The suggestions for next actions sound good too.
- Liz On Mon, Jun 5, 2017 at 2:36 PM, David Durst <ddu...@mozilla.com> wrote: > Hi. > > I wanted to call attention to https://bugzilla.mozilla.org/ > show_bug.cgi?id=1322554 (Startup crashes in BaseThreadInitThunk since > 2016-12-03) -- a startup crash resulting from DLL injection early in the > process -- which was resolved fixed for 32bit Windows on 5/24. > > This particular fix[0] has the potential side effect of solving other bugs > as well, ones that may have very different signatures that deal with > remotely-injected code[1]. > > Just a caution that it's not going to impact all injection issues. We know > that there is an as-yet-unidentified increase and decrease in this crash > prior to patch landing[2]. Carl Corcoran, who landed this, will be looking > at that time period as well to attempt to find contributing causes (any > help diagnosing is probably welcome, though I defer to ccorcoran). > > Also, just a shout out that this was Carl's first patch. > > Thanks! > > > [0] The proposed/chosen solution is roughly here: > https://bugzilla.mozilla.org/show_bug.cgi?id=1322554#c69 > [1] https://bugzilla.mozilla.org/show_bug.cgi?id=1322554#c168 > [2] https://crash-stats.mozilla.com/signature/?product= > Firefox&release_channel=release&signature=BaseThreadInitThunk&date=%3E% > 3D2016-12-05T14%3A42%3A31.000Z&date=%3C2017-06-05T14%3A42%3A31.000Z#graphs > > -- > David Durst [:ddurst] > > _______________________________________________ > Stability mailing list > stabil...@mozilla.org > https://mail.mozilla.org/listinfo/stability > > -- ---- Liz Henry (:lizzard) Firefox Release Manager lhe...@mozilla.com _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
