On Fri, Mar 17, 2017 at 6:31 PM, Mike Hommey <m...@glandium.org> wrote:
> On Fri, Mar 17, 2017 at 03:53:14PM -0400, Boris Zbarsky wrote:
>> On 3/17/17 3:40 PM, Ted Mielczarek wrote:
>> > We do try to build js/src pretty early in the build
>>
>> We do?  It's always the last thing I see building before we link libxul.
>> Seeing the js/src stuff appearing is how I know my build is about done...
>
> We don't try very hard, but it's also not listed to be last in the
> makefile that drives the build dependencies. In fact, it's in the middle
> of the dependencies for libxul... so I doubt even trying to move it
> there is going to affect the outcome much... At this point, someone
> needs to look at how Make actually orders the things it builds.

It is at least before all the libxul-specific code (i.e. code not in
mozglue/mfbt/external libs/etc.), but apparently that does not help
very much.

> It also doesn't help that Make (or ninja, etc. for that matter) is not
> aware of how long each target is going to take to build.

When this has come up in the context of ninja, the developer's
response has been that you should order your dependencies such that
things that take longer to build should appear earlier in the
dependency list.  I'd guess this is probably the same heuristic make
uses, although our recursive build structure probably doesn't play
very well with that.

-Nathan
_______________________________________________
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform

Reply via email to