On Fri, Mar 17, 2017 at 12:12 PM, Henri Sivonen <hsivo...@hsivonen.fi> wrote: > The callers aren't many, but they involve protocols and formats that > I'm not familiar with on the quirk level of detail: > https://searchfox.org/mozilla-central/search?q=symbol:_Z6IsUTF8RK10nsACStringb&redirect=false > > As a matter of API design, I disapprove of a method called IsUTF8 > doing something other than a pure UTF-8ness check. For example, the > reason why it now has the option to opt out of the non-character > rejection quirk is that Web Socket code used the function for what its > name says and that was a bug. Instead of changing the semantics to > match the name for everyone, an opt-out was introduced for callers in > Web Socket code.
I think all callers there look suspect and a couple I know for certain are wrong (e.g., Web Crypto, Ogg). And the misleading method name is probably to blame indeed. -- https://annevankesteren.nl/ _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
