On Sat, Feb 18, 2017 at 1:10 AM, Jean-Yves Avenard <jyaven...@mozilla.com> wrote:
> > > On 17/02/17 23:18, gsquel...@mozilla.com wrote: > >> Hi again Nick, >> >> Someone made me realize that I didn't fully read your message, sorry for >> that. >> >> I now see that as well as &&/||, you have grepped for other operators, >> and shown that the overwhelming usage is to put all of them at the end of >> lines! >> >> In light of this, and from what others here&elsewhere have discussed, I'm >> now thinking that we probably should indeed just update our coding style >> with whatever is used the most out there, and model our "Official >> Formatter" on it. >> >> >> Another thought, if technically possible: >> If our main repository is going to always be under the control of some >> official clang-format style, it should be possible for anybody to pull the >> repository, and use a different formatter locally with their favorite >> style. And when pushing, their modified code could be automatically >> reformatted with the official formatter -- Everybody feels good when >> programming! :-) >> >> > What worries me here, is that I'm yet to read a compelling argument on the > *why* people were doing things a particular way (with the exception of > David Major who provided a logical explanation for it). > > That you've done something out of habits for the last XX years is no > argument. Neither a "liking" for a form over another. > Actually, for matters of taste these seem like fairly compelling arguments, especially given the relative lack of evidence that most of these formatting questions actually materially impact code readability. I'd also note that if we're not going to use "this is what we have done historically" as a guide, then it seems like much bigger changes are on the table and we would probably be better off adopting some other well-defined coding standard wholesale (e.g., the Google C++ guide), with the decision largely being made on what has the best tooling available. Personally, I'd prefer this, but I haven't heard much enthusiasm for discarding a number of our style choices, however idiosyncratic they may be (aFoo, I'm looking at you). -Ekr _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
