Yeah, just to elaborate - it's still useful for Servo-only code to show up in searchfox, so that we know about consumers when changing things in the shared style system.
On Mon, Feb 13, 2017 at 11:46 AM, Bill McCloskey <[email protected]> wrote: > I just filed bug 1339165 to use this categorization in Searchfox. The order > of priorities would probably be: > > normal code > test files > non-Quantum Servo code > generated code > > -Bill > > On Mon, Feb 13, 2017 at 5:21 AM, Simon Sapin <[email protected]> wrote: > > > On 13/02/17 13:49, Henri Sivonen wrote: > > > >> A search like https://searchfox.org/mozilla- > central/search?q=EncodingRef > >> finds a bunch of stuff that is under servo/components/script/. I gather > we > >> don't use that part of Servo in Quantum. Correct? > >> > > > > Correct. > > > > > > How does one see which parts of servo/ are actually in use in Quantum? > >> > > > > I just came up with this: > > > > % cargo tree --manifest-path toolkit/library/rust/Cargo.toml \ > > --all-features --no-indent --all|grep -o '(.*)'|sort -u > > (file:///home/simon/gecko/gfx/webrender) > > (file:///home/simon/gecko/gfx/webrender_bindings) > > (file:///home/simon/gecko/gfx/webrender_traits) > > (file:///home/simon/gecko/media/libstagefright/binding/mp4parse) > > (file:///home/simon/gecko/media/libstagefright/binding/mp4parse_capi) > > (file:///home/simon/gecko/netwerk/base/rust-url-capi) > > (file:///home/simon/gecko/servo/components/config) > > (file:///home/simon/gecko/servo/components/geometry) > > (file:///home/simon/gecko/servo/components/selectors) > > (file:///home/simon/gecko/servo/components/style) > > (file:///home/simon/gecko/servo/components/style/gecko_bindi > > ngs/nsstring_vendor) > > (file:///home/simon/gecko/servo/components/style_traits) > > (file:///home/simon/gecko/servo/components/url) > > (file:///home/simon/gecko/servo/ports/geckolib) > > (file:///home/simon/gecko/toolkit/library/rust) > > (file:///home/simon/gecko/toolkit/library/rust/shared) > > (file:///home/simon/gecko/xpcom/rust/nsstring) > > > > If I got it right, these are all the Rust crates not pulled from > crates.io > > that can be enabled to be compiled in in libxul. I think there’s a couple > > more for unit tests. > > > > (Note that "cargo tree" is separate from the rest of Cargo. You need to > > run "cargo install cargo-tree" and add ~/.cargo/bin to $PATH to get it.) > > > > > > Is there a way to filter out the unused parts on Searchfox? > >> > > > > I don’t know. > > > > -- > > Simon Sapin > > > > _______________________________________________ > > dev-platform mailing list > > [email protected] > > https://lists.mozilla.org/listinfo/dev-platform > > > _______________________________________________ > dev-platform mailing list > [email protected] > https://lists.mozilla.org/listinfo/dev-platform > _______________________________________________ dev-platform mailing list [email protected] https://lists.mozilla.org/listinfo/dev-platform
