I have raised a bug[1] to block these types of commits in the future. This is an unnecessary risk that we are taking.
I also think that we need to remove this as acceptable practice from the MDN page. David [1] https://bugzilla.mozilla.org/show_bug.cgi?id=1336459 On 3 February 2017 at 15:11, Ryan VanderMeulen <rvandermeu...@mozilla.com> wrote: > A friendly reminder that per the MDN commit rules, the use of "No bug" in > the commit message is to be used sparingly - in general for minor things > like whitespace changes/comment fixes/etc where traceability isn't as > important. > https://developer.mozilla.org/docs/Mozilla/Developer_guide/ > Committing_Rules_and_Responsibilities > > I've come across uses of "No bug" commits recently where entire upstream > imports of vendored libraries were done. This is bad for multiple reasons: > * If makes sheriffing difficult - if the patch is broken and needs backing > out, where should the comment go? When it gets merged to mozilla-central, > who gets notified? > * It makes tracking a pain - what happens if that patch ends up needing > uplift? What about when that patch causes conflicts with another patch > needing uplift? What if it causes a regression and a blocking bug needs to > be filed? > > Bugs are cheap. Please use them. > > Thanks, > Ryan > > _______________________________________________ > firefox-dev mailing list > firefox-...@mozilla.org > https://mail.mozilla.org/listinfo/firefox-dev > > _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
