On Sunday, December 25, 2016 at 6:36:37 PM UTC-8, Mike Hommey wrote: > XP_GNOME comes to a surprise to me. But then it's only used in one > place, and defined in the same place, so it's a local thing...
Yea, it just so happens that it's browser.xul ;D But correct, it is a local thing. > As for MOZ_WIDGET_GTK vs. MOZ_WIDGET_TOOLKIT, there are 2 essentially > because you can't do things like "#if MOZ_WIDGET_TOOLKIT == foo" in C++ > code, although, come to think of it, we could have a MOZ_WIDGET(foo) > macro... > > Also note that generally speaking, there is a difference between the > platform (e.g. XP_WIN, XP_LINUX, etc.) and the widget > (MOZ_WIDGET_TOOLKIT). For example, while probably not true anymore, you > could build with the Gtk toolkit for Mac. So, generally speaking, there > is a need to differentiate both. That's a great point. If we could unify around two variables: - platform (win, macos, lin, etc.) - toolkit (gtk, cocoa, win, etc.) that would help me expose those two for localizers. Although quite honestly, I'd love to expose only one to localizers to differentiate strings upon. Probably toolkit is the right one for front-end strings. zb. _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
