On Sat, Aug 27, 2016 at 7:22 PM, Tim Guan-tin Chien <timdr...@mozilla.com> wrote:
> Hi :gps, > > The more I read into this, the more I think the hook might not likely fix > things. The hook would reject rename-only commits, but the hook would > likely not reject a rename commit from |foo| to |bar| and another rename > commit from |bar| to |Foo|. > > These two commits, as you pointed out, would still produce problems when > someone checks out the repo. > > Are we going to have the hook reject mismatched case of every filename > ever existed? That would be the only way to get away from any problems. > These observations are correct. Mercurial maintains a cache of every filename that ever existed. So checking for case collisions over all of time is possible and not super expensive. Whether we implement the hook to check for conflicts over all of time, I'm not sure. That's something we can discuss on the bug. > > > On Sun, Aug 28, 2016 at 2:30 AM, Mike Conley <mcon...@mozilla.com> wrote: > >> Yes, thank you Kan-Ru! >> >> On Aug 27, 2016 2:10 PM, "Nick Fitzgerald" <nfitzger...@mozilla.com> >> wrote: >> >> > Thanks Kan-Ru! I've personally tried to include the header with the >> wrong >> > case multiple times, so I appreciate this change a lot. >> > >> > On Fri, Aug 26, 2016 at 7:54 PM, Kan-Ru Chen <kc...@mozilla.com> wrote: >> > >> > > Hello, >> > > >> > > In Bug 1297276 I landed a patch to rename mozilla/unused.h to >> > > mozilla/Unused.h to make it more consistent with our other MFBT >> headers. >> > > Normally rename a header shouldn't cause too much trouble, however >> this >> > > rename is only changing the case so you might experience some problems >> > > on case insensitive filesystem. >> > > >> > > As pointed out by Tim in >> > > https://bugzilla.mozilla.org/show_bug.cgi?id=1297276#c19 if you use >> > > |git pull -f| to update local copy of gecko and git refuse to, you can >> > > rm mfbt/unused.* first to make git happy. >> > > >> > > HPH >> > > Kanru >> > > _______________________________________________ >> > > dev-platform mailing list >> > > dev-platform@lists.mozilla.org >> > > https://lists.mozilla.org/listinfo/dev-platform >> > > >> > _______________________________________________ >> > dev-platform mailing list >> > dev-platform@lists.mozilla.org >> > https://lists.mozilla.org/listinfo/dev-platform >> > >> _______________________________________________ >> dev-platform mailing list >> dev-platform@lists.mozilla.org >> https://lists.mozilla.org/listinfo/dev-platform >> > > _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
