Hi all, For web-platform-test, it seems some people still update manifest.json manually, instead of running "--manifest-update" mach command. Running "--manifest-update" assures the manifest to be in lexicographic order; however, manually updating manifest may sometimes accidentally add test info into a disordering place. Whenever we're in this disorder issue, we'll have to create an extra patch to fix this (like [1]). Doing so takes additional effort for both developers and reviewers, which should be avoidable. Therefore, I would like to see more people use --manifest-update instead of updating manifest manually.
BTW, if you find lots of unrelated gunk added to manifest after updating, probably you've encountered *Bug 1259775* <https://bugzilla.mozilla.org/show_bug.cgi?id=1259775> as well. This should only happen after adding reftest files, and a work around is mentioned in [2]. [1] https://reviewboard.mozilla.org/r/46665/diff/3#index_header [2] https://bugzilla.mozilla.org/show_bug.cgi?id=1259775#c3 Cheers, Jeremy Chen Software Engineer, Mozilla Corporation Tel: +886-2-8786-1100 #285 E-mail: [email protected] _______________________________________________ dev-platform mailing list [email protected] https://lists.mozilla.org/listinfo/dev-platform
