On 2016-04-11 19:47, Seth Fowler wrote:
Let me suggest again (especially since I'm not sure my previous email reached this list yet) that rather than compromise on the "e" prefix, we compromise on all caps for values, which is just as readable without placing even more pressure on our 80-character line length restriction.
I'm opposed to that, for the following reasons: 1. dropping the 'e' only makes the line shorter for single word values, and makes it *longer* for THREE_WORD_VALUES 2. many people read all-caps as SCREAMING 3. the claim that a single 'e' makes it harder to keep lines under 80 columns to any significant degree is extremely weak 4. the 'e' prefix is already the de-facto standard and widely used in our code base I do agree with you though that our 80-column rule produces awkward line-wrapping that makes it hard to read, write and review code. The solution to /that/ problem is to relax that rule so that using longer lines is allowed when code readability so demands. The root cause for this is usually our use of VeryLongAndDescriptiveNames (which is a good thing). We shouldn't sacrifice descriptive names, nor code readability, for this archaic 80-column rule. So, my counter-proposal is this: Try to keep lines to 80 columns or less, as a rule of thumb. Use up to 100 columns (hard limit) when code readability so demands. Thanks, Mats _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
