On Wed, Mar 30, 2016 at 1:11 PM, Nathan Froyd <nfr...@mozilla.com> wrote:
> On Wed, Mar 30, 2016 at 2:34 PM, Benjamin Smedberg > <benja...@smedbergs.us> wrote: > > I've been unhappy with the fact that our event loop uses refcounted > objects > > by default. *Most* runnables are pure-C++ and really don't need to be > > refcounted/scriptable. > > I've been thinking about this too. gfx has a separate thread pool > that was created partly because of the desire to be Gecko-free and > partly because of the overhead that nsIRunnable has. It would be nice > to eliminate one of those objections. Making this change would also > bring down bloat from vtables and essentially-useless methods. > Frankly, I think this is an ex-post-facto rationalization for not liking nsIRunnable because it's XPCOMy/not new and shiny/etc. We had this same problem with many of the same people and the same justifications with the mfbt RefCounted class that turned out to be a nightmare to untangle. Turns out things our boring old stuff had like leak checking were actually useful! Who could have guessed? Unless they have actual evidence showing this matters I don't care about their objections. *shots_fired.jpg* > I'm asking you to consider unifying these two things by making our event > > loop work more like chromium and just using c++ objects without a > refcount > > by default? Then to post a scriptable event to an event loop you'd have > to > > have it own a separate scriptable object. I'll pose to you the same question I posed bsmedberg, is this actually worth fiddling with all the existing runnables. It's not just scriptable stuff that needs to be changed. - Kyle _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
