We need to be careful with shuffling around #includes as there can be ordering dependencies that are not obvious at a glance.
Further, I don't think this is something worthwhile until we have a script that enforces said ordering. Thanks, Jared On Mon, Mar 28, 2016 at 5:20 PM, Nicholas Alexander <nalexan...@mozilla.com> wrote: > On Mon, Mar 28, 2016 at 1:28 PM, David Keeler <dkee...@mozilla.com> wrote: > > > (Everyone, start your bikesheds.) > > > > The style guidelines at > > > > > https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Coding_Style > > indicate that #includes are to be sorted. It does not say whether or not > > to consider case when doing so (and if so, which case goes first?). That > > is, should it be: > > > > #include "Foo.h" > > #include "bar.h" > > > > or > > > > #include "bar.h" > > #include "Foo.h" > > > > Based on the "Java practices" section of that document, I'm assuming > > it's the former, but that's just an assumption and in either case it > > would be nice to document the accepted style for C/C++. > > > > Not a comprehensive argument, but could we do what moz.build does for file > names? I believe that is case insensitive, and foo.h sorts before foox.h. > > Nick > _______________________________________________ > dev-platform mailing list > dev-platform@lists.mozilla.org > https://lists.mozilla.org/listinfo/dev-platform > _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
