On Wed, Mar 23, 2016 at 3:20 PM, Steve Fink <sf...@mozilla.com> wrote:

> On 03/23/2016 02:22 PM, Gregory Szorc wrote:
>
>> Bug 1254873 changed the default behavior of configure to not build the JS
>> shell by default for non-standalone JS builds. The reasons are outlined in
>> bug 1251324. tl;dr compiling the JS shell takes a non-significant amount
>> of
>> time for a feature that we believe most don't use.
>>
>> To continue building the JS shell, add `ac_add_options --enable-js-shell`
>> to your mozconfig.
>>
>> If you are doing a standalone JS build, the JS shell is still enabled by
>> default.
>>
>
> It appears that the automation builds still build the JS shell, though,
> correct? (It looks like it to me, which is good because I was going to
> complain about the difficulty of bisecting if not.)
>

Correct. See https://hg.mozilla.org/mozilla-central/rev/72e064358650#l3.1


> I was going to comment that mfbt test binaries are in a similar category,
> but I just tried --disable-tests and it seems to suppress them. Which is
> fine for the vast majority of my development builds, and it seems like
> something I should add to my JS shell automation builds as well.
>

My guess is mfbt test binaries are so small that we don't even notice
compiling them (at least compared to compiling JS foo). But I haven't
measured.
_______________________________________________
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform

Reply via email to