>> On 25/01/16 05:44 PM, Eric Rescorla wrote: >> >On Mon, Jan 25, 2016 at 1:58 PM, Mike Hommey <[email protected]> wrote: >> > >> >>It's also painful to use MozReview's comment system. The comments in the >> >>reviews pane don't show much diff context, and while I just realized >> >>it's possible to make it show more by hovering the diff part for a >> >>little while, it's not really great, as it doesn't actually show a diff >> >>view like the diff pane does, and switching to the diff pane a) is slow >> >>for large diffs and b) has an entirely different comment UX that doesn't >> >>seem really great either. >> >> >> > >> >Indeed. It would be great if it would just include 5-8 lines of context by >> >default.
> On Mon, Jan 25, 2016 at 06:15:10PM -0500, Andrew Halberstadt wrote: >> It's not terribly obvious, but instead of clicking on a line number you can >> click and drag on the numbers to set the exact amount of context you want. Mike Hommey writes: > Which is something for the person writing the comment to do. Yes, please. > Also, even when they do that, most of the time, that won't > contain the surrounding code. AFAICT it is a diff view, and, as you say, hovering provides access to the rest of the function/file, but the animation is quite slow. _______________________________________________ dev-platform mailing list [email protected] https://lists.mozilla.org/listinfo/dev-platform
