On 01/24/2016 04:48 AM, Mike Hommey wrote:
On Sat, Jan 23, 2016 at 09:33:15PM -0500, Boris Zbarsky wrote:
Sure. And the "r+ with these changes, and feel free to land, but I want to
see the interdiff" mode is supported with Autoland because the interdiff
would be available in mozreview post-facto, as you note.
Note that if /other/ changes from other bugs have happened to the same
files between the last reviewed iteration and the rebase before landing,
the interdiff will show them without any kind of visual cues. People
might think the interdiff problem is solved because mozreview uses a VCS
under the hood, but that's not true. In fact, in some cases it's worse
now, because while splinter could essentially tell you it can't display
an interdiff, mozreview will happily display you an interdiff that is
not what you'd expect.
Mike
Indeed. MozReview showing bogus interdiffs is rather major issue. It happens
also between
the changes for the same bug, if there are some file deletions etc.
_______________________________________________
dev-platform mailing list
[email protected]
https://lists.mozilla.org/listinfo/dev-platform
