On Thu, Jan 21, 2016 at 6:35 PM, Gregory Szorc <[email protected]> wrote: > > I've gotten into the habit of just landing things if I r+ them and I think > they are ready to land. This has startled a few people because it is a major > role reversal of how we've done things for years. (Typically we require the > patch submitter to do the landing.) But I think reviewer-initiated landing > is a better approach
I often ask for review first and only do a try run after I've gotten r+ and made any necessary changes. I also often make small changes after obtaining review (e.g. minor comment fix-ups). Both of these behaviours are incompatible with reviewer-initiated landing. Maybe I'm unusual. But I can definitely understand why people are startled. Nick _______________________________________________ dev-platform mailing list [email protected] https://lists.mozilla.org/listinfo/dev-platform
