On Mon, Nov 23, 2015 at 11:29:05PM -0800, Kris Maglione wrote:
> On Tue, Nov 24, 2015 at 04:08:56PM +0900, Mike Hommey wrote:
> >... which seems to be a *very* old thing because:
> >- resource://app might have pointed to the plain Firefox directory where
> > you could find the omnijar a long time ago (I don't remember if that
> > ever was actually true), but it points *inside* the omnijar now.
> >- omni.jar was renamed omni.ja a loooooong time ago.
> 
> Quite. There are some older ones, though:
> 
> list-style-image: 
> url("jar:resource://app/chrome/classic.jar!/skin/classic/browser/Toolbar-small.png")
> !important;
> 
> And some more recent ones:
> 
> list-style-image:
> url("resource://app/chrome/browser/skin/classic/browser/Toolbar.png")
> !important;

Note, depending on what those addons are trying to achieve with those,
it can be considered our fault that we don't have stable urls to access
data for themes (or locales, for that matter) that are not the current one.

Also note that the last form is valid but is currently broken.

> >>[1] https://mxr.mozilla.org/addons/search?string=resource%3A//app/
> >
> >Note this url is behind a "AMO Admins - LDAP Login" authentication
> >(which I probably don't have)
> 
> Any MoCo or MoFo account should have access by default.

Oh, it works.

So, if I believe this:
- https://mxr.mozilla.org/addons/source/4891/content/config.js#69
  Vimperator's import command is broken
- 
https://mxr.mozilla.org/addons/source/221523/components/nsIPXLNotificationCenter.js#165
  HTML5 Notifications might be broken
- https://mxr.mozilla.org/addons/source/242697/chrome/content/places.js#36
  https://mxr.mozilla.org/addons/source/242697/chrome/content/qrcode.js#233
  ViewMarks is likely broken

... and I stopped about halfway through the list and didn't look
thoroughly at the skin related things.

So I guess there are "only" probably less than a dozen addons actively
broken, but it might still be worth pushing for an uplift of the fix so
as to get it into 43.

Mike
_______________________________________________
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform

Reply via email to