Unfortunately, it looks like the kind of counter I would need is not yet supported[1].
Even if some bank in the world is using dialog=1, what does it give them? It doesn't change the behaviour of the window like showModalDialog (which runs in a nested event loop), it just changes the buttons available on the window chrome, and only on Windows. It also doesn't necessarily prevent the user from accessing those functions, since right-clicking on the titlebar allows the user to access a context menu for minimizing, maximizing, etc. So, to sum, dialog=1 seems to have a Windows-only cosmetic effect that only Gecko supports, and if anything, I would argue that it weakens user control by hiding functions that Windows user would expect on a popup. I've posted a patch in bug 1095236 that causes us to ignore dialog=1/dialog=yes from window.opens sent by content. Am I skipping any kind of procedure here in essentially deprecating a web feature? Is there an "intent to unship" thing that I need to do? Or some kind of group that I need to get sr from? -Mike [1]: Bug 1175033 On 02/10/2015 4:34 AM, Mike Taylor wrote: > > > On 10/2/15 2:53 AM, Ehsan Akhgari wrote: >>> Before I go whole-hog trying to fix bug 1095236, I'm curious to know if >>> we really want to continue supporting dialog=1 from content, or if it's >>> safe to just ignore that feature like the other browser engines (which I >>> think would be the fastest path towards fixing bug 1095236). >>> >>> Are there any really good arguments to keep supporting it? >> >> A good argument, no. But these things can end up having a web compat >> impact. I personally think that the risk of web compat is not that high >> here but if we want to be sure, we can add a use counter for the feature >> and measure how much it's used in the release population, and decide >> based on that. > > I agree with Eshan here. Usually it's banks scattered around the world > that depend on these obscure features. And banks are some of the > trickiest sites to diagnose (people don't trust me with their online > bank login details, weirdest thing) and *then* you have to convince the > bank to update their sites. > > But yeah, the guesswork goes away with a use counter. > _______________________________________________ dev-platform mailing list [email protected] https://lists.mozilla.org/listinfo/dev-platform
