On Fri, Oct 2, 2015 at 1:40 PM, Bobby Holley <bobbyhol...@gmail.com> wrote:
> On Fri, Oct 2, 2015 at 1:03 PM, Ehsan Akhgari <ehsan.akhg...@gmail.com> > wrote: > >> On 2015-10-02 2:42 PM, Jonas Sicking wrote: >> >>> It might still mean that we can save time on tryserver if we only >>> build these by default if the user has opted in to running the >>> relevant tests. >>> >>> I agree with Gregory. I really don't see much value in building these >>> binaries by default. For the people that use them often enough that >>> they are worth having, adding a line to mozconfig is easy enough. >>> >> >> There is one concrete advantage to building them, which is if your change >> ends up breaking some of them, you'll know immediately and you can fix it >> much faster than it you find out about it on the try server and/or on >> inbound. >> > > +1. I often break gtests when refactoring code, and it would be super > annoying to need to wait to find out about them on try. Given that this > impacts me as a bystander and not someone who runs those tests all the > time, I don't think that the right solution is for me to personally opt-in > to the old behavior in all of my mozconfigs. > Objections noted. I won't move forward and will retain status quo for now. _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
