On 2015-09-28 2:10 AM, Philip Chee wrote:
On 28/09/2015 02:29, Jörg Knobloch wrote:
This showed up on the Thunderbird development mailing list:
====
Hi.
I want to inform you that Thunderbird was checked by PVS-Studio (static
analyzer of C/C++ code). You can find summary of the check here
<http://www.viva64.com/en/b/0347/>. There is one false alarm as well as
author's mistake (getenv warning), it will be fixed.
Best regards, Igor Shtukarev.
====
Click the link and you'll be surprised.
Some (or most) of the errors are actually in M-C code.
I didn't check them all, but here are some beauties:
http://mxr.mozilla.org/mozilla-central/source/editor/libeditor/nsHTMLEditRules.cpp#7392
http://mxr.mozilla.org/mozilla-central/source/extensions/spellcheck/src/mozSpellI18NManager.cpp#31
http://mxr.mozilla.org/mozilla-central/source/xpcom/ds/nsWindowsRegKey.cpp#313
http://mxr.mozilla.org/mozilla-central/source/accessible/windows/sdn/sdnAccessible.cpp#223
If you follow the links to his website (http://www.viva64.com/), there
is a link to his Firefox analysis too[1]. Maybe he doesn't realize that
Firefox and Thunderbird share a lot of platform code?
The Firefox analysis is old, and we fixed some of the stuff it found
when it came out last year.
_______________________________________________
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform
