On 8/31/15 11:54 AM, Ted Mielczarek wrote:
On Mon, Aug 31, 2015, at 01:47 PM, Chris Peterson wrote:
>Should we hold third-party code to the same warning levels as Mozilla's
>home-grown code? When we find warnings in third-party code, we typically
>just suppress them because they weren't serious issues and fixing them
>upstream is extra work. Sometimes upstream doesn't care or want the
>fixes.
This is hard because it means that pulling in an update from upstream
can lead to bustage that needs to be fixed. I've hit this when updating
Breakpad before and it adds an extra layer of annoyance to an already
annoying update process. We can certainly try to upstream warning fixes,
but we shouldn't make life harder for ourselves either.
When I said we have typically suppressed third-party warnings, I meant
with CXXFLAGS += ['-Wno-whatever'] in moz.build, not modifying
mozilla-central's snapshot of the third-party code. I do not think we
should modify third-party code without an in-tree patch file or
upstreaming the fix.
_______________________________________________
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform
