On Wed, Aug 19, 2015 at 7:11 PM, Benjamin Smedberg <benja...@smedbergs.us> wrote:
> On 8/19/15 11:35 AM, Nathan Froyd wrote: > >> These statistics are reported through Telemetry. >> > Have the in-tree docs been updated to document this? I don't recall being > asked to review the final data collection proposal for this mechanism. > They have not. I didn't realize there were documents to update or that adding new histograms required separate review. > In particular: > > * Will this only collect to the opt-in (prerelease) population, or does > this also affect the release population? > Since these are just histograms within Telemetry, I assume this affects prerelease and release populations. (That was the intent, anyway; it's possible I didn't flip the right switches for this to happen.) * This involves collecting a numerator and denominator as separate > histograms, correct? > I don't know what numerator and denominator refer to here, maybe # of pages using feature and # of total pages, respectively? For each defined use counter, there are two separate boolean histograms. One describes the use of that thing for individual documents, and the other describes the use of that thing for "top-level" pages: basically what we think of as a "web page". So, scenarios: - Site X uses use counter Y. We report "used" (true) in both histograms. - Site X does not use use counter Y. We report "unused" (false) in both histograms. - Site X has an iframe for site W. Site W uses use counter Y, but Site X does not. We report one "used" and one "unused" in the individual documents histogram and one "used" in the "top-level pages" histogram. We went with two separate histograms because the second gives us a measure of "how many sites would be affected by removing this feature" that we couldn't get from the first one alone. * Is there reporting in place for this mechanism already? If not, who is > going to write that? > Since these are just histograms, reporting should not be a problem. There have been problems on the server-side when the first part of this landed back in May (bug 1168409), so it's possible that there are some changes needed on the server side for histogram validation, etc. * How are we going to do data-collection reviews for additions, especially > if the collection is added through WebIDL/UseCounters? > I do not know. hg push hooks? > * Is there a mechanism for auto-expiring data collection like there is for > histograms? > The histograms are currently set to never expire. It is probably worth rethinking that. -Nathan _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
