On Fri, Jul 24, 2015 at 2:06 PM, Philip Chee <philip.c...@gmail.com> wrote:
>
> Does PL_HashTableEnumerateEntries also need to be replaced? And if so
> what with?

That function operates on PLHashTable, which is part of NSPR. (Don't
confuse it with PLDHashTable, which is part of XPCOM, as are its
subclasses.)

It could be replaced with an iterator, though there are two wrinkles:

- nsprpub/lib/ds/plhash.c is C, not C++, which would make things harder.

- NSPR is kind of a pain to modify.

I wonder if converting all the uses of PLHashTable into PLDHashTable
would instead be a better approach. Either way, there aren't that many
uses of PL_HashTableEnumerateEntries() and I don't think anybody is
writing new code that uses PLHashTable, so it's not a compelling
change to bother with, IMO.

Nick
_______________________________________________
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform

Reply via email to