On Tue, Jul 07, 2015 at 05:09:57PM -0700, Gregory Szorc wrote: > On Tue, Jul 7, 2015 at 1:03 PM, smaug <sm...@welho.com> wrote: > > > As someone who spends more than 50% of working time doing reviews I'm > > strongly against this proposal. > > aFoo helps with readability - reader knows immediately when the code is > > dealing with arguments. > > > > > I'd like to point out that MozReview allows you to expand context when > doing code reviews. This means the necessity of extra "hints" in naming > conventions (such as aFoo) loses its importance. The argument that aFoo > assists with readability, while historically accurate when applied to > review tools such as Splinter that rely on patch/diff context, is thus > somewhat undermined by the employment of modern code review tool.
While mozreview helps to some degree, searching for the function declaration is not really something that is made easier by the context expansion feature it has. Mike _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
