On Tue, Jul 7, 2015 at 9:29 AM, Nathan Froyd <nfr...@mozilla.com> wrote:
> On Tue, Jul 7, 2015 at 11:49 AM, Mike Conley <mcon...@mozilla.com> wrote: > > > Aren't there tools for our (admittedly varied) editors / IDEs to make > > the readability that people are getting from aFoo readily available, but > > that don't also require us to pack it into the actual name of the > variable? > > > I find it useful for reading code in an editor, but I also find it useful > for reviewing patches when I don't have full context of the function. > Perhaps that will change with ReviewBoard and its ability to easily provide > context...or if ReviewBoard learned how to provide "this variable is a > (local|global|argument), set on line X" tooltips or something. There are tentative plans to integrate MozReview with DXR. Specifically, DXR and MozReview use the same code highlighting library ( http://pygments.org/). The goal is to develop a custom Pygments formatter that annotates the source code in MozReview with DXR-extracted metadata such as variable type, etc. This project is blocked on DXR indexing MozReview pushes, which is blocked on DXR 2.0 / rolling out DXR's support for indexing multiple revisions. Fortunately the latter is in progress. So hopefully this can happen by EOY. So, yeah, the end goal is for MozReview's code viewer to effectively be as intelligent as your IDE. I also have a pipe dream to enable code review to be conducted from IDEs. Lots of people like to pull commits, run the code with breakpoints, etc as part of code review. I think it would be rad if you could leave code review feedback directly in the IDE and then submit the review to MozReview. This would side-step the problem of DXR integration by offloading it to the IDE. Unfortunately, not everyone uses the same IDE and the effort involved is almost certainly greater. So DXR integration with MozReview will almost certainly happen first. _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
