On Thursday, June 18, 2015 at 7:28:44 AM UTC-7, kgu...@mozilla.com wrote: > 1) Comments that exceed the 80-char limit get wrapped blindly, rather than > being rewrapped properly. This results in comment blocks that look like this: > > // This is a comment that was previously just over the eighty > // character > // limit but got rewrapped by clang-format just blindly > // inserting > // linebreaks willy-nilly and requires manual fixup. > > I think this is an issue that should be fixed in clang-format. However, to > work around this incrementally I have been manually rewrapping comment blocks > in the APZ code if I'm touching them anyway.
Can we sidestep this by punting on enforcing a line length restriction with clang-format? I think it would be reasonably uncontroversial to just do the following initially: - spacing - indentation - bracing > 2) MOZ_BEGIN_NESTED_ENUM_CLASS seems to trip up the formatter and it > misformats the code after that. AFAICT there's no such thing as MOZ_BEGIN_NESTED_ENUM_CLASS -e _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
