On Wed, Jun 17, 2015 at 4:57 PM, Nicholas Nethercote <[email protected]> wrote: > (At this point I expect people to push back against my claims that the > automated tools aren't up to snuff. If you really think automated > tools can do a good enough job, please run one and submit patches > fixing up some files. I'd be happy to help review.)
I used to think that the tools were good. Then we did some analysis on clang-format and found that it had a few shortcomings. See https://bugzilla.mozilla.org/show_bug.cgi?id=1118245 for some of that discussion. In particular, a hard line length limit turned out to be an issue when it came to automatic formatting. We do want an 80 character limit, but there are cases where - without manually moving code around - a few extra characters can mean a huge difference in readability. Of course, most of this can be attributed to old, terrible code. Most of us are doing more important things and so haven't gone back to this yet. _______________________________________________ dev-platform mailing list [email protected] https://lists.mozilla.org/listinfo/dev-platform
