On 06/04/2015 05:30 AM, Ehsan Akhgari wrote: > There are very good reasons for warnings to not cause tests to fail. We > have a lot of tests that are testing failure conditions that are > expected to warn, because they are failure conditions.
Also: in layout, there are various warnings related to coordinate wraparound/overflow, where we're basically throwing up our hands and warning that broken layout is likely to occur because the page is millions of pixels tall. These can be useful hints, when debugging page brokenness. We have a lot of tests that exercise how we behave around this coordinate-overflow threshold [mostly that we don't crash], and it's expected that such tests would trigger these warnings. One thing that might help for noise from these: Jesse filed a bug[1] a while back on adding a flag to detect huge sizes & suppress some assertions when we do; we could conceivably use this flag to suppress warnings [perhaps just displaying a single "detected huge sizes" warning], as well. ~Daniel [1] https://bugzilla.mozilla.org/show_bug.cgi?id=765861 _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
