Thank you for the feedback, you make some good points.
On Friday, May 22, 2015 at 1:31:14 AM UTC-7, masayuki nakano wrote:
> Hi,
>
> I still want a same level as PR_LOG_ALWAYS.
Would switching this to the new level 'Info' suffice? The main difference is
that by enabling the Info level you will also see Error level messages as well.
Currently it is the other way around, enabling Error level messages also
enables Always level messages.
> In nsTextStore which is an implementation of ITextStoreACP of TSF uses
> PR_LOG_ALWAYS only logs the module behavior. I.e., we can use to check
> specific IME behavior with this level. I don't like to call this as
> "error". And also I wrote some documents how to log IME behavior. For
> backward compatibility with such documents, I think that the "info"
> should behave as PR_LOG_ALWAYS. SO, I think that the new enum should be:
I agree that calling those messages "error" is undesirable, my hope is that
using "info" will be a good substitue.
Can we update these documents? When we add new ways to turn on logging at
runtime we will need to update the
> enum class LogLevel
> {
> Disabled = 0, // Logging is disabled for this module
> Info,
> Error,
> Warning,
> Debug,
> };
This diverges a fair amount from the established ordering of various other
logging frameworks (see Ted's follow up, as well as mhoye's).
_______________________________________________
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform
