On 05/07/2015 02:53 PM, Karl Tomlinson wrote: > The warning that you are proposing to fix here is > -Woverloaded-virtual. [EDIT: karl meant to say > -Winconsistent-missing-override] > > At least once we can build with this warning enabled, I recommend > making this warning fatal instead of covering over it by adding an > override annotation that the author may have never intended.
Semi-tangent, to correct one premise here: Good news -- we already *can & do* build with this warning (-Winconsistent-missing-override) enabled, and it's fatal in FAIL_ON_WARNINGS directories which is most of the tree. bug 1117034 tracks a lot of the fixes for that. You just need clang 3.6 or newer to get this warning, and our official TreeHerder clang builders have an older version, so they don't report this warning. As a result, we get a few new instances checked in per week -- but I've been catching those locally (since they bust my build) and I've been fixing them as they crop up. (But anyway, as ehsan replied separately, his proposed coding style change isn't about fixing instances of this build warning.) </semi-tangent> _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
