Nathan suggests the following plan to avoid code duplication: 1) Move STS code into xpcom/io under a different name and XPCOM uuid. 2) Make the necko STS a no-op inherit from the xpcom code with a different uuid.
This would give us two service instances without duplicating any code. Also, I'll clarify this comment to indicate what the different sservice instances are for. Right now it kind of suggests people use STS for file streams: https://dxr.mozilla.org/mozilla-central/source/netwerk/base/nsIStreamTransportService.idl#14 Any objections? Thanks. Ben On Thu, Mar 26, 2015 at 10:08 AM, Patrick McManus <mcma...@ducksong.com> wrote: > thanks bkelly > > On Thu, Mar 26, 2015 at 9:01 AM, Benjamin Kelly <bke...@mozilla.com> > wrote: > >> Actually, I'm going to steal bug 990804 and see if we can get something >> worked out now. My plan is just to duplicate the STS code with a >> different >> XPCOM uuid for now. >> >> On Thu, Mar 26, 2015 at 9:29 AM, Benjamin Kelly <bke...@mozilla.com> >> wrote: >> >> > On Thu, Mar 26, 2015 at 2:46 AM, Randell Jesup <rjesup.n...@jesup.org> >> > wrote: >> > >> >> Some examples pointed out to me: FilePicker, the spell-checker, the >> >> DeviceStorage DOM code, DOM cache code in Manager.cpp (via >> >> BodyStartWriteStream()), even perhaps ResolvedCallback in >> >> ServiceWorkers. (I haven't looked closely at all of the uses yet.) >> >> >> > >> > Sorry for this. Obviously there has been some confusion as I was >> > explicitly directed towards STS during the DOM Cache development. (I >> even >> > thought there was a separate SocketTransportService which was different >> > from StreamTransportService.) >> > >> > In any case, I wrote a bug to fix the Cache issue: >> > >> > https://bugzilla.mozilla.org/show_bug.cgi?id=1147850 >> > >> > I will try to fix this in the next couple weeks. >> > >> > Sorry again. >> > >> > Ben >> > >> _______________________________________________ >> dev-platform mailing list >> dev-platform@lists.mozilla.org >> https://lists.mozilla.org/listinfo/dev-platform >> >> > _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
