On Mon, Mar 16, 2015 at 5:44 AM, Ehsan Akhgari <ehsan.akhg...@gmail.com> wrote:
> On 2015-03-15 11:26 PM, Seth Fowler wrote: > >> >> On Mar 15, 2015, at 6:26 PM, Joshua Cranmer [image: 🐧] < >>> pidgeo...@gmail.com> wrote: >>> In general, std::pair should be preferred over mozilla::Pair unless you >>> need the empty type optimization. >>> >> >> If that’s the case, perhaps we should rename it to e.g. >> mozilla::CompactPair? It’s current name strongly suggests that it should >> serve as a replacement for std::pair. >> > > Sounds like a good idea. Given that we've been living with this in our code so far (except for UniquePtr), and that we'll get this when tuple becomes usable, this seems like a rather temporary benefit at the cost of baking in yet another mozilla-specific non-STLism. My proposal would be instead to make this an inner class and encourage people to use tuple when it becomes available. -Ekr _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
