On 01/15/2015 09:31 AM, Bobby Holley wrote: > On Wed, Jan 14, 2015 at 5:37 PM, Steve Fink <sf...@mozilla.com > <mailto:sf...@mozilla.com>> wrote: > > On 01/14/2015 11:26 AM, Ehsan Akhgari wrote: > > From now on, the only supported build mode is unified > compilation. I > > am planning to follow-up with removing support for the > > --disable-unified-compilation configure option altogether in bug > 1121000. > > I commented in the bug, but I guess this is probably a better forum. > > Why is the configure option being removed? I understand always > building > unified in automation, but not having a straightforward way at all to > see if your code is buggy seems... suboptimal. If someone wants to go > through occasionally and make our codebase valid C++, how should > they do > it after this change? > > > IIUC, in the absence of somebody committed to doing this on a daily > basis, we will quickly slide towards hundreds of include errors, and > the configure option will quickly become useless.
If that is the case, then adding a file has the potential of exposing a bunch of those include errors, if it perturbs the chunking boundaries. But we've already had that argument, and decided in favor of always building unified in automation. I think the question of removing the configure option is separate. It's ok if we gradually accumulate these errors. I just don't want to make life unnecessarily hard for the occasional angelic figure with supernatural papercut fixing abilities (hi cpeterson!). And if this is actually useful to a subset of people (eg IDE users), then perhaps the debt won't build up too much. Personally, I do occasionally run a build, grab the compile command, change the *unified*.cpp file to just the file I'm interested in, and rerun. But that's a very niche use. _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
