Ehsan Akhgari <ehsan.akhg...@gmail.com> wrote:
> On 2015-01-02 2:03 PM, Brian Smith wrote:
>> In this case, the problem is that I wrote a patch to explicitly delete
>> ("= delete") some members of classes in mozilla::pkix. mozilla::pkix
>> cannot depend on MFBT for licensing and build independence reasons
>> (e.g. so it can be put into NSS). I don't want to add the equivalent
>> of MOZ_DELETE to mozilla::pkix just to make MSVC2012 work.
>
> = delete currently cannot be used in Mozilla code according to
> <https://developer.mozilla.org/en-US/docs/Using_CXX_in_Mozilla_code>.
I realize that now. It is very unfortunate that the rules for using
C++ in Mozilla code are not simply "if it passes tryserver, it's OK."
I hope that Mozilla accelerates its deprecation for old compilers (GCC
less than 4.8, in particular, so that "enum class" can be used safely)
and improves the automation.
> I am
> not sure why you don't want to add the equivalent of MOZ_DELETE given how
> easy that is.
> Our personal opinion about MSVC2012 aside, without a decision
> to drop support for MSVC2012, we cannot say no to fixing the build issues
> specific to that compiler, and such decision has not been made so far.
First, I will back out the offending patch pending a resolution of
this discussion, in the interests of being a good team player while
this discussion unfolds. I've already asked a VS2012 user to review
the patch here:
https://bugzilla.mozilla.org/show_bug.cgi?id=1117003#c3
However, I think my time is better spent arguing for dropping MSVC2012
support (and allowing "= delete") than writing another "= delete"
macro. So, let's try to resolve that it is OK to drop MSVC2012 support
in Firefox 37 now.
>> We shouldn't hold people to supporting MSVC2012 without a way to
>> verify that MSVC2012 can build the code correctly on tryserver. That
>> is, it is unreasonable to require that "we won't check in patches
>> that require compiler features that 2012 does not support" if MSVC2012
>> is not in tryserver. It's especially an unnecessary burden on us
>> independent contributors.
>
> FWIW people fix compiler issues that cannot be tested on try server all the
> time.
Because I develop on Windows and most others develop on Linux, I am
disproportionately involved in these bugs, which usually affect
differences in fail-on-warnings behavior between Windows and newer
clang versions. That's why I'd like for us to resolve to move forward
to increasing minimum compiler versions at a faster pace, because that
seems like an effective and cheap way of reducing the occurrences of
such issues.
Cheers,
Brian
_______________________________________________
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform
