On 2014-12-17 1:11 PM, Gregory Szorc wrote:
On 12/17/14 9:32 AM, Ehsan Akhgari wrote:
On 2014-12-17 11:40 AM, Ted Mielczarek wrote:
On 12/17/2014 10:19 AM, Ehsan Akhgari wrote:

Apple unfortunately doesn't ship the headers and libraries required to
build against that clang, and if you try to compile the plugin against
headers/libraries obtained from elsewhere there is a good chance that
the plugin won't work, so your best bet is to download
<http://llvm.org/releases/3.5.0/clang+llvm-3.5.0-macosx-apple-darwin.tar.xz>


and extract it somewhere and point the CC, CXX and LLVMCONFIG
variables to the binaries in that package in your .mozconfig.

Is this something we ought to consider adding to mach bootstrap, or at
least adding some optional way to simplify this?

What do you mean by "this"?  Downloading clang?  That seems to be simple
enough.

Simple for the initiated. Any step that stands between a potential
contributor wanting to patch Firefox and that patch landing should be
turnkey and automated as much as possible. Every step is a hurdle where
we can lose a potential contributor. Mike Hoye can articulate this point
far better than I can. Talk to him if you want more details.

Perhaps I don't understand exactly what's being suggested here. Downloading a package of clang is absolutely *not* a requirement for new contributors, they can use their system gcc/clang as we have broad support for various versions of both of those compilers.

That being said, if someone wants to add a mach command for this, please go ahead by all means. I definitely have no objection.
_______________________________________________
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform

Reply via email to