On Tue, Nov 25, 2014 at 11:07 PM, Mook < mook.moz+nntp.news.mozilla....@gmail.com.please-avoid-direct-mail> wrote:
> On 11/25/2014 10:28 AM, Bobby Holley wrote: > >> On Sun, Nov 23, 2014 at 4:43 PM, Mark Hammond <mhamm...@skippinet.com.au> >> wrote: >> >>> * If it is supposed to be used with a normal return, is the change so >>> GetPendingResult() is called the correct approach to take? (ie, should I >>> open a bug with that as the patch?) >>> >>> >> At a high level yes, but I haven't looked at the code to determine if that >> precise fix is right. Please file a bug with the patch flag me for review. >> >> FWIW, this is bug 287107 - it would be useful to check against when > happened when an attempt was made to fix it in 2005 (and got backed out). > > There are few callers that use this API in tree because it's been broken > for nearly a decade :) > Brendan describes the problem causing the backout here: https://bugzilla.mozilla.org/show_bug.cgi?id=287846#c9 AFAICT this is all a moot point given that there are almost no consumers of Components.returnCode left in the tree. _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
