On 11/21/14 8:49 AM, L. David Baron wrote:
On Friday 2014-11-21 12:51 +0100, David Rajchenbach-Teller wrote:
>Well, for one thing, it's not self-documenting.
We should comment them better (i.e., have a bug on each one, and
point to the bug in a comment on the expectAssertions line). I
wasn't able to do that when initially landing the assertion checking
because, at the time, there were too many to keep up with the tree.
At this point I could probably go back through the data I used for
that to annotate the remaining ones.
A self-documenting expectAssertions API might take an array of bug
numbers (for expected assertions) as a function argument instead of an
expected assertion count.
For extra credit, expectAssertions could use the Bugzilla API to
validate the bug numbers are relevant assertions and not RESOLVED FIXED. :)
chris
_______________________________________________
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform
