I am glad to hear there is so much activity happening there. Kind of makes my point though: that code needed it :)
Andreas On Oct 16, 2014, at 8:03 PM, Josh Matthews <j...@joshmatthews.net> wrote: > I'm not certain that the image/src/ code is as bad as you make out any more. > bholley certainly is no longer the expert there; I took over a bunch of his > work to clean it up a year or two ago, and Seth is the benevolent dictator > now and has done some good cleanup work on it as well. > > Cheers, > Josh > > On 2014-10-16 6:45 PM, Andreas Gal wrote: >> >> The code is really bizarre, needlessly complex and impossible to understand >> and maintain. We could use a lot of improvements in this area to better >> decide what images to load when and how and when to retain or purge them. >> There is a lot of state machinery and multi-threading at work. I wouldn’t be >> surprised if we find a couple nasty correctness bugs if we ever decide to >> clean up this mess. bholley is the expert for this code I think. He can give >> you a better overview (full disclosure: this code used to be much worse >> before he went to town on it). >> >> Andreas >> >> On Oct 16, 2014, at 7:33 PM, Nicholas Nethercote <n.netherc...@gmail.com> >> wrote: >> >>> On Fri, Oct 17, 2014 at 8:55 AM, Andreas Gal <andr...@mozilla.com> wrote: >>>> >>>> I would like to nominate image/src/* and in particular its class hierarchy >>>> which completely doesn’t make any sense what so ever. imgRequest, >>>> imgIRequest, we got it all. >>> >>> Does this cause correctness problems, or is it just hard to read and >>> thus modify? Is there a path that could be taken to gradually improve >>> it? >>> >>> Nick >> > > _______________________________________________ > dev-platform mailing list > dev-platform@lists.mozilla.org > https://lists.mozilla.org/listinfo/dev-platform _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
