Hi, I am not sure where to post, but since this affects every platform, here it goes.
I noticed several months ago that some javascript test programs that run during |make mozmill| test suite wait for dialogs during the execution. But I also realized that there is no distinction for dialogs. That is, whatever dialog appears at the time when the test program expects a particular dialog to appear in the test scenario seems to let the test programs assume that they are seeing THE dialog that they expect at the point of the test execution. Well, this is not quite correct sometimes. Program may show unexpected error dialog/popup due to coding error which the test program does not expect. While debugging, I noticed a few programs saw unexpected dialogs, but thought they were seeing the correct dialogs they expected and ran to the later step of the test scenario. This is not quite desirable, and one of the deficiencies of the current testing framework. I think the test framework should stop the test execution and print failure then and there. I think we need to enhance the wait for dialog to specify which dialog to wait to avoid this "unrelated dialog satisfies the test scenario expecting a particular dialog to appear". But then I realize that the current dialog mechanism may not have such an identifier. (Maybe we can use the string or part of the string that is shown in the dialog as a key to distinguish different dialogs? Of course, change to existing dialog mechanism may be in order. test script can be enhanced later. We can add a wait-for-dialog API with an identifier argument and gradually change over to the new APIs by replacing the wait for dialog where problems are noticed in test scenarios. So the test scripts do not have to change overnight although the core dialog implementation needs to add such ID and a means to check the ID of a displayed dialog.) I noticed such erratic behavior of unexpected dialog fooling the test program into thinking it is seeing an expected dialog during |make mozmill| since one of my PCs somehow failed the access to (remote) mail account information database during mail account creation, and TB was showing the failure to access such database, but the test program(s) thought they saw expected dialogs for dialog creation and got stuck later due to missing data, etc. [If the code has changed in the last several months to support such IDs for dialogs, please disregard this message.] TIA _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
