On Thursday, December 19, 2013 6:28:07 PM UTC+1, Bobby Holley wrote: > Off-the-shelf automated tools are not going to solve our formatting woes. > > Both the JS engine and Gecko mandate very particular patterns. I ended up > > writing a custom python tool to reformat XPConnect a few years ago [1] > > because none of the tools were configurable enough. > > > > I think detailed style guides are hugely important, because developers have > > a spec to code to, and don't have to try to read the reviewer's mind. In > > SpiderMonkey, there's been a push to document the outcome of every style > > discussion in the style guide. The SM style guide now has a lot of detail > > on how these edge cases should be handled (see [2]), and I find it very > > helpful. > > > > On this issue specifically - email seems to be garbling the alignment of > > the proposals (at least for me). Can anyone with a proposal (baku, Ms2ger) > > resend it as a pastebin? > > > > [1] https://bugzilla.mozilla.org/show_bug.cgi?id=688012 > > [2] > > https://wiki.mozilla.org/JavaScript:SpiderMonkey:C_Coding_Style#Other_whitespace
Maybe we could use a hierarchical structure for the lint rules. At the top of the tree there are general rules, that are very weak - e.g. don't have trailing white-spaces and a maximum of 100 characters per line. Further down into the tree, the linting rules get more specific and teams implement their own rules, then then also lint properties depending on the used framework etc. Maybe such an approach could be taken for mozilla-central? _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
