I’m open to either options. So the current proposal is keeping tests with external access *in the same directory* as existing tests governed by manifest files. Good to know that adding another directory is something to avoid.
-edwin On Aug 14, 2014, at 2:31 PM, Ehsan Akhgari <ehsan.akhg...@gmail.com> wrote: > On 2014-08-14, 5:00 PM, Edwin Wong wrote: >> >> Hi Ms2ger, >> >> Thanks for calling me on that, just trying to move things along. >> >> Test location and using manifests concepts can also be decoupled. Wherever >> the location the tests, we will use manifests to define it’s execution. >> There isn’t really any other way around that. >> >> So now the decision is, do we want to: >> 1. keep external access tests in the same directory as other tests [1] >> 2. group external access tests into a directory named ‘external’ (e.g. >> dom/media/tests/mochitest/external/) >> >> Many of the QA team believe option #2 is ideal in addition to using >> manifests to define them. > > Please keep the tests *in the same directory*. Given that the source of > truth is the manifest declaration, the separate directory isn't necessary. > We have been trying to reduce the depth of our directories where it's not > necessary to have subdirectories and it would be very sad to see a new source > of unneeded directory nesting. > > (Note that there is already precedence for putting tests from *different* > frameworks, for example mochitest-plain and chrome, in the same directory.) > > Thanks! > Ehsan > _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
