On Thu, Aug 14, 2014 at 12:00 PM, Neil <n...@parkwaycc.co.uk> wrote: > Well there's your problem: GetWSBoundingParent doesn't need to own the nodes > it works on.
Editing code is ancient, poorly maintained, and not performance-sensitive, so personally, I don't ever use raw pointers as local variables in editor/. Better to not have to rely on manual review to prevent use-after-free bugs. I am aware of at least one sec-critical bug in editor that resulted from non-use of nsCOMPtr that slipped through review when someone was rewriting editing code. In this case, I seem to remember I wanted to change it to return a raw pointer instead of already_AddRefed, but IIRC, Ehsan said not to (although I can't find that anywhere, so maybe I made it up). _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
