On 7/29/14, 12:27 AM, Mike Hommey wrote:
On Tue, Jul 29, 2014 at 02:59:17PM +0800, Philip Chee wrote:
On 29/07/2014 08:32, Mike Hommey wrote:
Hi,
I'd like to inform you today that choosing the right variable when
adding a new directory to the tree just got a lot easier with the
landing of bug 1043802 and bug 1043820 (on mozilla-inbound only at
the moment). Before, you had to choose from:
- DIRS
- PARALLEL_DIRS
- TEST_DIRS
- TOOL_DIRS
- TEST_TOOL_DIRS
The choice is now reduced to:
- DIRS
- TEST_DIRS
The distinction that existed with PARALLEL_DIRS, TOOL_DIRS and
TEST_TOOL_DIRS are now irrelevant.
Cheers,
Mike
How about parts that should not be built with PARALLEL_DIRS ?
There are 4 phases to the build.
- export, which has been all parallel whether you use PARALLEL_DIRS or
DIRS for a while
- compile, which is all parallel whether you use PARALLEL_DIRS or DIRS
(it's been all parallel for a while, but recent changes moved things
that weren't, and they are now because we have all the required
dependencies)
- libs, which contrary to its name, now doesn't have anything to do with
libraries, and has been all sequential whether you use PARALLEL_DIRS
or DIRS for a while.
- tools, which used to do a lot but does almost nothing, now, and has
been all sequential whether you use PARALLEL_DIRS or DIRS for a while.
In other words, the distinction between PARALLEL_DIRS and DIRS is
irrelevant. (It was still relevant before the change that moved things
from libs to compile)
In case that didn't answer the question, we still do have
cross-directory dependencies in the tiers/phases that are parallel.
There is a mechanism to define those. However, if you find yourself in
that situation, a build peer should be involved. Introducing these
cross-directory dependencies makes the build slower and this is
something we want to keep in check via review.
_______________________________________________
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform
