On Fri, Jun 6, 2014 at 8:35 PM, Boris Zbarsky <bzbar...@mit.edu> wrote:
> https://tbpl.mozilla.org/?tree=Try&rev=e26ab6d5e1e0 says we have quite a 
> number of things that are in fact assuming that 5 and "5" should test is().  
> I'm not sure how much I like throwing in tons of toString() for that case.

Why should you need .toString()?  Just change the expected result.  Like here,

http://dxr.mozilla.org/mozilla-central/source/dom/base/test/test_url_empty_port.html#27

  is(url.port, 8080, 'URL.port is 8080');

should just become

  is(url.port, '8080', 'URL.port is 8080');

This is something I could look at fixing when I next have time, if no
one else gets to it first.  Should be a lot less work than fixing
every misuse of nsresult and nsnull in the tree.  :)
_______________________________________________
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform

Reply via email to