On 6/4/14, 2:21 PM, James Graham wrote:
* They encourage the use of deepEqual which has underdefined semantics,
particularly in the case of objects that contain cycles (it looks like
Assert.jsm goes into an infinite loop in this case, but I may have
misread the code).

You didn't misread the code, and that's exactly what it does. See https://bugzilla.mozilla.org/show_bug.cgi?id=1010344 for an example where this bit us recently. And yes, your typical use of deepEqual is probably broken.

* The throws method encourages lazy testing since it doesn't provide any
way to inspect the properties of the thrown exception.

100% agreed.

-Boris
_______________________________________________
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform

Reply via email to