On Wed, May 21, 2014 at 4:36 AM, Nicolas Silva <nical.si...@gmail.com>wrote:
> Honestly, I don't mean to start a bikeshed about whether we should enforce > strict rules about this project-wise, because I know that people have > different tastes as to whether writing "Size" is vastly better than > "gfx::Size". But I'd like to encourage people to carefully make use of this > c++ feature, especially when the namespace in question is used a handful of > times in the file. I personally will be strict about it the reviews I give. > I don't think we should have rules that some reviewers enforce and others don't. That makes life hard for everyone. It's not clear to me how moving the "using namespace" declaration inside a namespace helps. Won't most files in a unified build translation unit put their declarations in the same namespace, negating any benefit? Personally I find unified-build-related using-namespace errors are rare --- I've not encountered one yet. I'm not sure they're worth attempting to ameliorate. Rob -- Jtehsauts tshaei dS,o n" Wohfy Mdaon yhoaus eanuttehrotraiitny eovni le atrhtohu gthot sf oirng iyvoeu rs ihnesa.r"t sS?o Whhei csha iids teoa stiheer :p atroa lsyazye,d 'mYaonu,r "sGients uapr,e tfaokreg iyvoeunr, 'm aotr atnod sgaoy ,h o'mGee.t" uTph eann dt hwea lmka'n? gBoutt uIp waanndt wyeonut thoo mken.o w _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
