On Mon, May 19, 2014 at 7:25 AM, Nicholas Nethercote <n.netherc...@gmail.com> wrote: > Hi, > > Do we still need Trace Malloc? I suspect it's barely used these days. > For memory profiling, we have about:memory and DMD. For shutdown leak > detection we have ASAN and Valgrind. > > Trace Malloc is documented here: > https://developer.mozilla.org/en-US/docs/Mozilla/Debugging/Debugging_memory_leaks#Trace_Malloc > > Trace Malloc is enabled for all TBPL debug builds. I'm not sure why; I > did a try run today where I disabled it and it was green. > > It's used to get stacks within the deadlock detector, but I'm not sure > if that's necessary, and it doesn't seem like it would be that hard to > replace if it is necessary. > > There's also Leaky, which is documented on the abovementioned wiki > page. I think it works in tandem with Trace Malloc, and may be a > candidate for removal as well. > > Thanks. > > Nick > _______________________________________________ > dev-platform mailing list > dev-platform@lists.mozilla.org > https://lists.mozilla.org/listinfo/dev-platform
Probably not. As you say, if you really do want all the detail ASAN covers your use case. Otherwise, about:memory provides a far better summary and diff view. I think ultimately dbaron would need to sign off on removing it but I have no objections. - Kyle _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
