On Mon, 5 May 2014, Robert O'Callahan wrote: > > drawSystemFocusRing is a rather bad name since most calls to it will > draw nothing. drawCustomFocusRing is an even worse name since it will > draw nothing approximately always. > > drawFocusIfNeeded replaces drawSystemFocusRing, which is the method we > expect people to need much more than drawCustomFocusRing. > drawCustomFocusRing should change, but I'm not sure what to since its > name needs to indicate both that it doesn't usually draw anything and > its return value must be checked and properly used. I think it makes > sense to use the short name for the method that is both simpler and the > API most authors should be using.
drawFocusIfNeeded() isn't a particularly good name either, since you're not drawing the focus, you're drawing the focus ring. I suppose if drawFocusIfNeeded() is the best we can come up with for drawSystemFocusRing(), then drawCustomFocusRing() could maybe become "shouldDrawFocus()". In any case, the right place for these discussions would be a public standards list, like the WHATWG list, so that all the interested parties (in particular, authors) could have visibility into the discussion. -- Ian Hickson U+1047E )\._.,--....,'``. fL http://ln.hixie.ch/ U+263A /, _.. \ _\ ;`._ ,. Things that are impossible just take longer. `._.-(,_..'--(,_..'`-.;.' _______________________________________________ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform
