(2014/04/19 22:54), Benjamin Smedberg wrote:
On 4/18/2014 7:07 PM, ISHIKAWA,chiaki wrote:
Does anyone know how to disable this prefixing short of modifying the
source code?
Why can't you just accept this in your parsing regex?
There is no runtime control for this behavior. It was made non-optional
so that we could which process an assertion was coming from when child
processes are present (plugins, content, eventually sandboxed media
decoders).
http://hg.mozilla.org/mozilla-central/annotate/db431ea44a1a/xpcom/base/nsDebugImpl.cpp#l311
--BDS
Thank you for the clarification.
Actually, my regex used in the summary creation script did try to
accommodate this change.
But the simple-minded sum, etc. using shell and commands no longer works
after the change, thus I was curious about restoring the
old behavior.
I created the shell scripts long time ago without
bothering to use anything more powerful (awk, perl, etc.) for
scanning through the TB test log quickly.
When I notice that a particular error/warning occurs very frequently or
shows up in the list for the first time, that is where I devote my
debug time.
I am debugging the summary creation shell script now, but I am afraid
that has become very error-prone :-(
The shell script without trying to use advanced tools such as awk and
perl is very simple-minded.
Say, for summary of WARNING lines coming from |make mozmill| and |make
xpcshell-tests| of full debug version of TB (comm-central),
I used to use a simple-minded shell script as follows:
e.g.: the following line printed out how many times
a particular WARNING with NS_ENSURE was produced during the run.
egrep "WARNING" $1 | egrep NS_ENSURE | grep -v "sort operation has
occurred for the SQL statement" | sort | uniq -c | sort -n -r
Now, I am struggling with the following change, but still not producing
the desired result yet:
egrep "^(\\[[0-9]*\\] |)WARNING" $1 | egrep NS_ENSURE | grep -v "sort
operation has occurred for the SQL statement" | sort | uniq -f1 -c |
sort -n -r
As I write this, I realized I am missing a field selection for the "|
sort |" portion in the pipeline. I guess that is why I don't seem to
get desired summary.
(But, of course, I have to figure out if I may be missing
WARNING lines without "[PID] " prefix if such lines exist. I hope not.)
Anyway, I have about a dozen lines of shell pipeline commands in the
summarizing script which broke due to the change,
and so was interesting in how to shut up the
PID prefix selectively. I will look into the above source code (maybe a
local patch to change behavior based on environment variable.)
I agree that the new prefix is indeed useful for tracking down
issues to figure out which message is coming from which process when a
parallel testing (of running many tests at once) is done.
When a nasty bug appears, it is rather difficult to correlate the
message to which process, I agree.
|make xpcshell-tests| runs many tests in parallel, and so will benefit
from the change.
OTOH, |make mozmill|, the main TB test suite runs test more or less in
serialized manner: after all testing mail client requires the simulation
of mail creation, sending, or mail receiving, etc. using a shared local
mail DB for a user and you can't run user interaction in parallel, and
thus "[PID ]" prefix is not that useful there.
So it is a matter of what is sought.
I hope the build infrastructure can use the "[PID] " prefix to
track down and co-relate the messages with tests with more exactness so
that debug/test can proceed more efficiently.
We need tryserver runs to catch more errors in a meaningful manner.
Currently, the so called "tests" simply pass individual tests that
produce dubious error/warning lines during execution as long as
the sought criteria is met, but I think that ought to change.
TIA
Thank you for clarifying the
_______________________________________________
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform
